MODx CMF

The right-click menu has "publish" and "unpublish" links. These events (before/after publish; before/after unpublish) are not represented in the list of available events in modx_system_eventnames. Note: We have the same problem with onDocFormUndelete and onBeforeDocForm Undelete, see issue MODX-189). The situation with publishing and unpublishing, though, is more complicated. When viewing the editing interface for a document, there is a button at the top of the page to delete it, so using a single system event (e.g. onDocFormDelete) makes sense, even though the right-click menu in the document tree never accesses the "DocForm". And even though the undelete process is not represented in the system events, a basic solution is relatively easy, and has been posted in issue MODX-189. (Though I will add that changing the "delete" button to say "undelete" when in the DocForm would be even better.) With publishing and unpublishing, there is no button at the top. It's a checkbox on the second page of information about the page. So the only way to publish or unpublish a document from the DocForm is by saving the document. This means that the OnDocFormSave and OnBeforeDocFormSave events are triggered, but not there is no separate process to handle events like onDocFormPublish. It doesn't exist in the DocForm at all. There is a separate process, though, in the right-click menu of the document tree. With this discrepancy, it might be more appropriate to call the event "OnDocPublish" rather than "OnDocFormPublish," but since publishing and unpublishing do deserve their own events, I would vote to create a button at the top for publishing and unpublishing, and removing the checkbox. This would make things more consistent overall and would allow the same event to be triggered, whether from the DocForm or from the right-click menu. If this is done, the names of the system events should include the "Doc" reference (onDocFormPublish, onDocFormUnpublish, onBeforeDocFormPublish, and onBeforeDocFormUnpublish).