MODx CMF

outdated issue.
Waiting for updated lang files to make a new patch.

Hi Max, any news on a patch or is this still an on-hold issue?

I have made all changes. But one question, what about alpha sorting?
I want to sort lang files. Make all files to one format.

And what about this string:
include_once(dirname(_FILE_).'/english.inc.php'); // fall back to English defaults if needed
in some lang files?
Kill them?
found in:
bulgarian.inc.php
english-british.inc.php
francais-utf8.inc.php
francais.inc.php
japanese-utf8.inc.php
persian.inc.php
portuguese.inc.php
spanish.inc.php

Example of alpha sorting in attach.
Approve please =)
UPD: If this sorting will be approved, I will sort all other lang files.

one more lang file.... http://svn.modxcms.com/jira/browse/MODX-406

Best wait until we know we have a full complement of updated lang files before doing the alpha-sorting. Aside from that, I don't see a problem with the alpha-sorting.

include_once(dirname(FILE).'/english.inc.php'); // fall back to English defaults if needed

This line needs to be kept in, it's so that language files that haven't been updated to the latest version of the english.inc.php still display something for any new language strings that have been added. Better to display the english version than nothing at all

Manager works fine even if you dont include english file (except login page).
ok. now its clear for me.

What about making $_lang["credits_shouts_msg"] and $_lang["mgrlog_query_msg"] to one line?

Maybe sort just english file?

What is the status on these updates? Are these still relevant, or have updates to language files in the meantime addressed these issues?

Ok. Here we go!
Following files has been modified.

chinese.inc.php
finnish.inc.php
francais.inc.php
francais-utf8.inc.php
german.inc.php
italian.inc.php
japanese-utf8.inc.php
nederlands.inc.php
norsk.inc.php
polish.inc.php
portuguese.inc.php
russian.inc.php
russian-UTF8.inc.php
simple_chinese-gb2312.inc.php

Only one string has been modified - "preview_msg" to english like format. Removed images.
Also removed duplicate string in finnish file.
Apply this as fast as you can to prevent more work with new lang files.

and.. two questions:
Alpha sorting - when? I can sort all lang files.
What about $_lang["credits_shouts_msg"] and $_lang["mgrlog_query_msg"] to single line?

Ok. New lang files.. I need to make a new patch.

Max, can you take a peek at Commit 5007-5009 and see if it resolves this report. I think should resolve the majority of the issues.

Check my changes in english file:
Make single quotes to double (for one format):
$_lang['database_version']
$_lang['role_export_static']
$_lang['role_import_static']

Make all strings to one line:
$_lang["credits_shouts_msg"]
$_lang["mgrlog_query_msg"]

And sort real Alphabetically

What do you think?

Ok. some new changes.

Make double quotes to single:
"documents in this container"
"This container does not have child-documents."
"MODx version"
"First"
"Go to page"
"Last"
"Version codename"
"View children"

and updated string from 5009.

What tool do you use for sotring?

And why in your sorting underscore goes last?

when we decide what sorting to choose, and sort files, I'll make a patch.

Just committed 5076 for the English lang file ... lots of cleanups and inconsistencies indeed. There will be some additional language strings needed for the other languages. Perhaps we should create a guide that explains the proper way to sort and update launguage files?

Thanks Max.

For sorting I use Microsoft Excel

For updating language files (when there are new strings) I think Compare soft is best.
But today, in the internet there are services for translating files.

Is the sorting not as you would expect now? Do we need to keep this issue open for the time being, or can it be closed?

I don't understand, why in your sorting underscore goes last?
May be we should to create voting, to see what sorting is preferred by people?

In my opinion, first must go underscore. (see example in 144 issue)

We close this issue, when we decide what sorting to choose. Then, I can sort all files, and make a patch (I wrote before, what problems I solve).

Patch will goes here.

Sorting will goes http://svn.modxcms.com/jira/browse/MODX-144

I'm simply using the sorting in TextMate to sort the lines. I'm not sure what algorithm it uses for sorting. Can you give me an example of the underscore sorting last vs first?

Here's some info on how Textmate sorts: http://wiki.macromates.com/FAQ/ShellScriptCorner

I've now run the file the unix sort command: sort -fud and it's sorted as I think you'll agree is the correct order. Thanks for being patient with me! Commit #5093

Much better, but I'm not satisfied yet.
I'm experimenting with textmate.. still no results.
Why not satisfied?
Look at screenshot.
textmate sorting (on the left) and good sorting. (right)

Left side - textmate
Right side - Excel ;D

FINALLY!
I GET IT!
use sort -n
Now sorting problem resolved.

Continue patching..

I'm making patch right now.
Please, don't commit changes in non english files.

IMPORTANT: and no sorting before I will make a patch. (because need to fix many single\double quotes problem and make all strings to single lines)

Ok..
I have finished to analyze lang files.
It was the big headache.
I fix the norsk lang file (\n\n was broken - just new lines)
But polish files... its little hell. They broke \n\n symbols.. and now they have just "nn" and new lines and other consistency problems. (It's look like some reg exp was used)

What about 3 polish files?

polish-iso02.inc.php
polish-utf8.inc.php
polish.inc.php

Is it safe to replace "
n" with "\n" ? (only chinese and russian files got a lot of this) I change it to \n

OMG. I finished.
I proud to present my huge patch for all manager lang files (not install).
I don't want to post all changes.. You can see it in patch.

Patch for 5097
Updated Russian lang file Included.

Next checkpoint - sorting http://svn.modxcms.com/jira/browse/MODX-144

Again.. many fixes in lang files. Now for Installer.
big changelog...again

Ready for sorting.

The .jp install file failed but I think I manually fixed that. Please double check for me if you would in commit #5101.

Some problems on the patch for a few of the languages. The rest went well in commit #5102:

patching file manager/includes/lang/chinese.inc.php
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 169.
Hunk #3 FAILED at 486.
Hunk #4 FAILED at 497.
Hunk #5 FAILED at 912.
5 out of 5 hunks FAILED – saving rejects to file manager/includes/lang/chinese.inc.php.rej

patching file manager/includes/lang/persian.inc.php
Hunk #1 FAILED at 8.
Hunk #2 FAILED at 154.
Hunk #3 FAILED at 232.
Hunk #4 FAILED at 358.
Hunk #5 FAILED at 371.
Hunk #6 FAILED at 496.
Hunk #7 FAILED at 522.
Hunk #8 FAILED at 606.
Hunk #9 FAILED at 952.
Hunk #10 FAILED at 982.
10 out of 10 hunks FAILED – saving rejects to file manager/includes/lang/persian.inc.php.rej

patching file manager/includes/lang/portuguese-br.inc.php
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 8.
Hunk #3 FAILED at 154.
Hunk #4 FAILED at 175.
Hunk #5 FAILED at 234.
Hunk #6 FAILED at 441.
Hunk #7 FAILED at 498.
Hunk #8 FAILED at 608.
Hunk #9 FAILED at 723.
Hunk #10 FAILED at 770.
Hunk #11 FAILED at 869.
Hunk #12 FAILED at 960.
12 out of 12 hunks FAILED – saving rejects to file manager/includes/lang/portuguese-br.inc.php.rej

patching file manager/includes/lang/simple_chinese-gb2312.inc.php
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 8.
2 out of 2 hunks FAILED – saving rejects to file manager/includes/lang/simple_chinese-gb2312.inc.php.rej

Attached 4 files.
Can you just replace with fixed files?

And about sorting. Files was prepared for sorting. Not sorted yet!
I thought you will sort them.

Do you mind if I sort them?

Committed #5103. Sort away!

I have a 2 questions:
What to do with 3 polish file? (2 of them - iso)
What to do with $_lang["not_set"] string? English file doesn't contain this string, but it still in use in
manager\actions\mutate_content.dynamic.php

Many lang files contain both strings - not_set and notset.

Let me know, what to do with this.

Attached sorted files.
Removed deprecated strings from all files. (except not_set, until we decided what to do)
"Begin" string was changed to "begin"

Some of the same failures this time as last. Committed in #5105, #5106 and #5107.

There are some significant issues with the chinese.inc.php file that I can't seem to fix manually. Looking at it in my text editor, the syntax highlighting is crazy, so I think there may be some core problems in general with it.

patching file manager/includes/lang/chinese.inc.php
Hunk #1 FAILED at 8.
...

The legacy Polish file is in there for legacy reasons. The proper solution would be to update the upgrade script to move any legacy Polish files from the Legacy translation to the matching encoding/new translation. Can you handle this one as well Max?

The $_lang["not_set"] string was added back to the English file in commit #5107. There should be no more occurrences of "notset" in any language files or manager files.

Attached chinese file.

I'm not really understand what do you want to do with polish files.
All files identical. Only encoding is differs.

And please, edit your post about lang files. I mean "sort -fud".

The original Polish language file is in the ISO-8859-2 encoding, and was the only one included. Now that there are multiple file encodings available, it may make sense to update the filenaming convention to include the encoding in the filename. Though to be fair, I think this is a better idea and the way we'll go for a future update. Consider this one closed (I'll remove the duplicate file).

Any more needed on this one or on MODx-144 Max? Would love to shut it down!

144, 200 - done.

Attaching a patch between Evo/0963 for reference

Diff between Evo and 0963 English language files